Implement Undo/Redo #4

Franciman · 2020-11-09T00:23:01+01:00

Franciman commented

2020-11-09 00:23:01 +01:00

It seems to be working correctly.
Before the merge I would like a brief review, because I changed some bits.

I introduced a type alias Canvas for Vector<CanvasElement> to make signatures shorter, maybe a better name is due, (possibly we want an Abstract Data Type here, so we can abstract on the data structure, but not on this branch)

It seems to be working correctly. Before the merge I would like a brief review, because I changed some bits. I introduced a type alias `Canvas` for `Vector<CanvasElement>` to make signatures shorter, maybe a better name is due, (possibly we want an Abstract Data Type here, so we can abstract on the data structure, but not on this branch)

enrico reviewed 2020-11-09 10:12:42 +01:00

enrico approved these changes 2020-11-09 10:23:29 +01:00

src/lib.rs

													
				@ -39,0 +84,4 @@

				        // so we first check if there are newer versions, if so

				        // this means we are in the past, so a change in the past destroys the future

				        // and creates a new future. If we want to keep all ramifications, we should use a tree,

				        // but honestly, this sounds like overkill.

enrico commented

2020-11-09 10:15:35 +01:00

I agree, I’ll leave out this consideration before pushing

Franciman marked this conversation as resolved

src/main.rs Outdated

													
				@ -26,2 +26,3 @@

				    current_element: Option<CanvasElement>,

				    elements: Vector<CanvasElement>,

				    //elements: Vector<CanvasElement>,

				    history: History,