enrico
/
stiletto
1
1
Fork 0
Code Issues 27 Pull Requests 3 Releases Wiki Activity

Tools v2 #12

Merged
enrico merged 1 commits from tools_v2 into master 2021-12-02 02:54:39 +01:00
Conversation 1 Commits 1 Files Changed 4 +115 -78
enrico commented 2020-11-25 01:17:48 +01:00
Owner
Copy Link

This integrates the tools branch experimentation inside the master branch.
The UI currently sucks, but it is good enough. No support for tool parameters modification yet.

In the next commit I'll hook up CanvasToolCtx so that it allows the current drawing functionality.

After merging, I'll take care of rebasing the eraser branch work on top for this.

This integrates the tools branch experimentation inside the master branch. The UI currently sucks, but it is good enough. No support for tool parameters modification yet. In the next commit I'll hook up CanvasToolCtx so that it allows the current drawing functionality. After merging, I'll take care of rebasing the eraser branch work on top for this.
enrico changed title from Tools v2 to [WIP] Tools v2 2020-11-25 01:17:56 +01:00
enrico requested review from Franciman 2020-11-25 01:21:46 +01:00
enrico commented 2020-11-28 21:46:24 +01:00
Author
Owner
Copy Link

After having dubbled a bit with implementing the CanvasToolCtx, I came to the conclusion that a tool context is like a widget.
In the future I would like to experiment to that a CanvasToolCtx implements druid::Widget.
With the current design, CanvasToolState would be an aggregate of all the possible states of all possible tools, which is undesirable.

Nonetheless, I would merge this and improve the design at a latter stage.

After having dubbled a bit with implementing the CanvasToolCtx, I came to the conclusion that a tool context is like a widget. In the future I would like to experiment to that a CanvasToolCtx implements druid::Widget. With the current design, CanvasToolState would be an aggregate of all the possible states of all possible tools, which is undesirable. Nonetheless, I would merge this and improve the design at a latter stage.
enrico changed title from [WIP] Tools v2 to Tools v2 2020-11-28 21:46:37 +01:00
enrico merged commit 3c6f161a54 into master 2020-12-02 19:33:56 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Franciman
Labels
Clear labels   
blocked-on-druid

Issue blocked on druid backend

  
bug

Something is not working

  
drawing

Related to drawing algorithms and data structures

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
ui

Related to user interface

  
wontfix

This won't be fixed

No Label
blocked-on-druid
bug
drawing
duplicate
enhancement
help wanted
invalid
question
ui
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: enrico/stiletto#12
No description provided.
Delete Branch "tools_v2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?