Enrico Lumetti enrico
  • Joined on 2019-09-21
enrico opened issue enrico/stiletto#8 2020-11-09 20:33:30 +01:00
Make serde_bare work
enrico merged pull request enrico/stiletto#6 2020-11-09 20:31:51 +01:00
Basic Open/Save mechanism
enrico pushed to master at enrico/stiletto 2020-11-09 20:31:51 +01:00
2ddfef8416 Merge pull request 'Basic Open/Save mechanism' (#6) from save_load into master
cfa925da2f Use file dialogs to open/save files
e6885125af Basic Open/Save mechanism, with hardcoded file name
Compare 3 commits »
enrico commented on pull request enrico/stiletto#6 2020-11-09 20:31:42 +01:00
Basic Open/Save mechanism

This is good enough for now, I'm opening separate tickets for the other issues

enrico pushed to save_load at enrico/stiletto 2020-11-09 20:29:39 +01:00
cfa925da2f Use file dialogs to open/save files
e6885125af Basic Open/Save mechanism, with hardcoded file name
8f7e073c4c Remove notebooks for the time being; they are still in history
c4ae8836e6 PDF Page annotation analysis
1dac92b03b entries per sec analysis
Compare 6 commits »
enrico commented on pull request enrico/stiletto#7 2020-11-09 19:02:57 +01:00
WIP: Eraser implementation

It still fits the CanvasData, because it is a piece of data associated to the Canvas (indeed, the currently drawn item). When there is no currently drawn item, is set to None; for the time being, current_element != None is the result of is_drawing()

enrico commented on pull request enrico/stiletto#7 2020-11-09 17:19:00 +01:00
WIP: Eraser implementation

I'm not sure about this code: if a line intersects a Rect, but the line start and end are outside of the rect, will this return true?

enrico commented on pull request enrico/stiletto#7 2020-11-09 17:19:00 +01:00
WIP: Eraser implementation

I think we should split the various parts in more Canvas::Freehand parts. This way, when we implement selection etc, we can identify paths with a single connected stroke

enrico commented on pull request enrico/stiletto#7 2020-11-09 17:19:00 +01:00
WIP: Eraser implementation

Maybe "add_element"?

enrico commented on pull request enrico/stiletto#7 2020-11-09 17:19:00 +01:00
WIP: Eraser implementation

Nice

enrico commented on pull request enrico/stiletto#7 2020-11-09 17:19:00 +01:00
WIP: Eraser implementation

I'm not sure that current_element should be associated with the Pen; a Pen should have thickness and color informations only

enrico commented on pull request enrico/stiletto#7 2020-11-09 17:19:00 +01:00
WIP: Eraser implementation

I feel like we should use a state machine to identify the state the app or the canvas is in; maybe this would simplify this logic, or at least make it more explicit

enrico commented on pull request enrico/stiletto#7 2020-11-09 17:19:00 +01:00
WIP: Eraser implementation

lol the name choices are unfortunate

enrico commented on pull request enrico/stiletto#7 2020-11-09 17:19:00 +01:00
WIP: Eraser implementation

I think this is fine for now

enrico commented on pull request enrico/stiletto#7 2020-11-09 17:19:00 +01:00
WIP: Eraser implementation

This is clearly an important architectural piece, some work is needed, but we're heading in the right direction

enrico pushed to master at enrico/stiletto 2020-11-09 16:09:17 +01:00
8f7e073c4c Remove notebooks for the time being; they are still in history
c4ae8836e6 PDF Page annotation analysis
1dac92b03b entries per sec analysis
Compare 3 commits »
enrico pushed to save_load at enrico/stiletto 2020-11-09 16:05:19 +01:00
6ed45013f7 Basic Open/Save mechanism, with hardcoded file name
b211c07ff6 Basic Open/Save mechanism, with hardcoded file name
Compare 2 commits »
enrico pushed to save_load at enrico/stiletto 2020-11-09 16:04:55 +01:00
b211c07ff6 Basic Open/Save mechanism, with hardcoded file name
503f5ddaf3 Basic Open/Save mechanism, with hardcoded file name
Compare 2 commits »
enrico created pull request enrico/stiletto#6 2020-11-09 16:01:29 +01:00
Basic Open/Save mechanism, with hardcoded file name
enrico pushed to save_load at enrico/stiletto 2020-11-09 15:59:09 +01:00
503f5ddaf3 Basic Open/Save mechanism, with hardcoded file name